Skip to content

Bug 1734136: aws/defaults/platform: Default to m5 in ap-east-1 #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

Bug 1734136: aws/defaults/platform: Default to m5 in ap-east-1 #2108

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jul 26, 2019

This is an automated cherry-pick of #1755

/assign wking

@wking
pkg/types/aws/defaults/platform: Default to m5 in ap-east-1
800fbac 
The Hong Kong region is new 2019-04-25 and does not support the older
m4 types [1].  This pull-request adds it (commented out in validation,
because we don't push RHCOS AMIs there).  It also expands the seeded
regions in TestGetDefaultInstanceClass to gets the tests to pass:

  platformtests/aws$ AWS_PROFILE=openshift-dev go test .
  ok  							 github.com/openshift/installer/platformtests/aws			26.282s

[1]: https://aws.amazon.com/blogs/aws/now-open-aws-asia-pacific-hong-kong-region/
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 26, 2019

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.1] aws/defaults/platform: Default to m5 in ap-east-1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 26, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 26, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 26, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign wking
You can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Jul 26, 2019

Not referenced directly by rhbz#1725524, but we need to backport #1755 to avoid this conflict when backporting #1935.

@wking wking changed the title [release-4.1] aws/defaults/platform: Default to m5 in ap-east-1 Bug 1725524: aws/defaults/platform: Default to m5 in ap-east-1 Jul 26, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 26, 2019

@openshift-cherrypick-robot: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1725524: aws/defaults/platform: Default to m5 in ap-east-1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 26, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 27, 2019

@openshift-cherrypick-robot: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 800fbac link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Jul 27, 2019

/retitle [release-4.1] aws/defaults/platform: Default to m5 in ap-east-1

This bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1725524 doesn't seem to belong to changeset.

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot changed the title Bug 1725524: aws/defaults/platform: Default to m5 in ap-east-1 [release-4.1] aws/defaults/platform: Default to m5 in ap-east-1 Jul 27, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 27, 2019

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.1] aws/defaults/platform: Default to m5 in ap-east-1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 27, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 27, 2019

@abhinavdahiya: This pull request references a valid Bugzilla bug.

Details

In response to this:

/retitle [release-4.1] aws/defaults/platform: Default to m5 in ap-east-1

This bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1725524 doesn't seem to belong to changeset.

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 27, 2019
@wking
Copy link
Member

wking commented Jul 29, 2019

/retitle Bug 1734136: aws/defaults/platform: Default to m5 in ap-east-1

We now have an ap-east-1-specific 4.1.z bug, so reference it.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.1] aws/defaults/platform: Default to m5 in ap-east-1 Bug 1734136: aws/defaults/platform: Default to m5 in ap-east-1 Jul 29, 2019
@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 29, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 29, 2019

@openshift-cherrypick-robot: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1734136: aws/defaults/platform: Default to m5 in ap-east-1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Jul 30, 2019

We're not planning on supporting ap-east-1 in 4.1.z.

/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 30, 2019

@wking: Closed this PR.

Details

In response to this:

We're not planning on supporting ap-east-1 in 4.1.z.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@wking wking

Labels

bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @wking @abhinavdahiya